I always thought Dylan McDermott from "The Practice" (the precursor to "Boston Legal") had great style. Â Unfortunately, in the real world, most male attorneys resemble Justice Kennedy more than Dylan McDermott.
It is true that lawyers in general dress poorly -- I think the biggest mistake is the plain white shirt. Â I hardly ever wear a plain white shirt. Â I like very pale blue, a pale lavender, a pale pink and then go with patterns from there (I prefer thin stripes for professional wear; but I'd go with a lot of checks if I had the choice).
I agree with your opinion about plain white shirts, but think that patterns are more versatile than colored shirts. Â Colored shirts are also a bit edgy for the office environment, except for blue, which is so common as to become cliched.
If I could make a comment about lawyers, it is that the shoes are normally hideous.
I think this statement is applicable to men generally. Â I have seen many an outfit that was otherwise put together well completely ruined by cheap and ugly shoes. Â Men need to realize that an outfit is only as good as its weakest link.