I honestly can't comment on whether it's more or less correct, historically speaking. Fred Astaire notwithstanding, I simply think it breaks up the line of the trousers too much. I little bit of color in the socks can be good, but a serious break in color or shade has to be done very carefully.
I was less concerned about historical correctness than aesthetics, myself. I think Astaire had less contrast than I do, though. What I like about these is that they're a little striking, but not in a "he's wearing pink socks!" way. Worst case scenario, I save them for my new light gray suit.